Commit Graph

2242 Commits

Author SHA1 Message Date
lawnjelly
2b70218bd1 Fix uninitialized data reads in Input
Found by Valgrind.
2022-09-16 23:35:56 +02:00
lawnjelly
41cc0cd554 Fix RayCast2DEditor uninitialized value
node was previously read before being set. Found by Valgrind.
2022-09-16 23:35:04 +02:00
lawnjelly
0dc54e449a Fix GLES directional shadow uninitialized data
Valgrind shows directional_shadow.fbo accessed when uninitialized in directional_shadow_create.
2022-09-16 23:33:38 +02:00
lawnjelly
264627d11b FlowContainer fix uninitialized data
This uninitialized data was finding its way into the renderer.
2022-09-16 23:31:58 +02:00
lawnjelly
95dddc0e9e FindBar fix uninitialized results_count
Found by Valgrind.
2022-09-16 23:31:04 +02:00
lawnjelly
a39a25694d Batching - fix uninitialized color read
Valgrind was showing a read from uninitialized memory. r_fill_state.curr_batch->color is unset (for performance reasons), so can contain random data.

This actually doesn't matter in practice, since logically this uninitialized state can only occur when change_batch is set, and the only side effect is that change_batch is set. Hence why no bugs occur in practice.

This PR prevents this read from uninitialized data. It is likely free in terms of performance after optimization, and keeps the Valgrind logs clearer, so why not.
2022-09-16 23:30:31 +02:00
Maxim Kulkin
4237a6501f Add GraphNode 'selected' and 'unselected' signals, simplify GraphEdit
Backport of the fix from master to 3.x
2022-09-16 23:29:52 +02:00
Fredia Huya-Kouadio
58e935b746 Disable logic that triggers automatic focus gain as the Godot Editor is loaded
For the Godot Android Editor, this is an inconvenience as it causes the soft keyboard to show and block half of the view
2022-09-16 23:28:31 +02:00
kobewi
e133069bda Add Dictionary.find_key() 2022-09-16 23:20:06 +02:00
Rémi Verschelde
72f7c01c22 HTML5: Fix warning with Emscripten 3.1.20
And use that version for CI.
2022-09-16 23:18:43 +02:00
Micky
7f3a0cbd0a Modify newlines in Editor Spin Slider tooltip
Makes both key suggestions easier to read.

(cherry picked from commit a2ba189fef5d7e8b0278c8de3802fb925097befa)
2022-09-16 23:16:49 +02:00
Leonardo Santagada
4673ebaf90 Mention an issue with infinite scroll on mirroring of Parallax layer
(cherry picked from commit 74df54a99e3e20d2e3378a7cf5c655a1727bb8c9)
2022-09-16 23:16:13 +02:00
kobewi
b5b6d14d37 Fix Viewport size change not updating textures
(cherry picked from commit 3a4a4aeadec36324da394238cf0f86dbac345e93)
2022-09-16 23:13:40 +02:00
98039d80f6 Fix include. 2022-09-16 23:12:05 +02:00
Rémi Verschelde
67ea3b41f5 SCons: Enforce version 4.0+ when compiledb=yes is used
Fixes #65233.

(cherry picked from commit 6c5e085d1317df8576b78f0f0ca90a2fff364664)
2022-09-16 23:10:16 +02:00
BenniKane
06ddad7cd6 doc: Clarifying NavigationAgent and NavigationAgent2D velocity_computed requires avoidance_enabled to be true to emit
(cherry picked from commit ed5b832a81bb7f67924282d2c3f96b8674ecbb7d)
2022-09-16 23:08:49 +02:00
ad17c39ad4 Fix compile. 2022-09-16 23:06:25 +02:00
Micky
4487e18750 Mark Script button if it's tool in Scene Tree Editor
Also adds a note on the tooltip if the Script is tool.

The color is the same one used on the Script Editor's script list.

(cherry picked from commit ad5ff9f78fe0bab4572085803f224026273fd4aa)
2022-09-16 23:04:00 +02:00
kobewi
c954a6c9d7 Mention that grab_focus is more reliable deferred
(cherry picked from commit 188d5593e1f080181a6e0302b7d54416d2cd96e8)
2022-09-16 23:02:09 +02:00
kobewi
65e1217d59 Allow to change the Stop shortcut used at runtime
(cherry picked from commit 409613ba7ba50e6cc985c61f6dcc482bac68746e)
2022-09-16 22:59:29 +02:00
Micky
9086bef38d Cast between float and ints in SceneTreeTween.tween_property()
(cherry picked from commit 2b18a4002c8e500597bc8f5d605f9be8d1b22236)
2022-09-16 22:55:03 +02:00
Rémi Verschelde
c708c44180 SCons: Refactor LTO options with lto=<none|thin|full>
Adds support for LTO on macOS and Android.
Disable LTO by default on iOS even if `production=yes` is set.

Also add `linker` option to `server` platform missed in #63283.

Refactor code handling old arguments to make it simpler (breaks compat,
but is explicit enough about it and scripts are easy to fix).
2022-09-16 22:54:09 +02:00
Hugo Locurcio
f90d0cb9d0 Improve documentation related to audio input permissions 2022-09-16 22:50:34 +02:00
Marcel Admiraal
226e29cfca Fix Geometry::get_closest_points_between_segments() returns NaN
Also fix Geometry::get_closest_distance_between_segments() returning
incorrect values.
2022-09-16 22:48:50 +02:00
Fredia Huya-Kouadio
cddfcbab2c Fix build failures for Android on Windows
The issue is caused by https://github.com/godotengine/godot/pull/64306 which makes use of a 3.7 feature while the current recommended python version is 3.5 for 3.x and 3.6 for master.

(cherry picked from commit 667f4ed742e0010adb678dff45e004310c4886d4)
2022-09-16 22:47:48 +02:00
Pedro J. Estébanez
ba9d7d66fd Add ability to extend the set of Git pre-commit hooks
(cherry picked from commit 8e2d0e1bb16409ad2e32e6e59432ffafb03c14ee)
2022-09-16 22:47:07 +02:00
Pedro J. Estébanez
866f38a8ae Make Git hooks work on worktrees on Windows
(cherry picked from commit 4bf03afe8b70062cfca3336527294171e538ce25)
2022-09-16 22:46:13 +02:00
Fredia Huya-Kouadio
a6a5b60235 Additional fixes to the Android get_current_dir() implementation. 2022-09-16 22:45:21 +02:00
6a317fbe15 Fix build. 2022-09-16 22:42:11 +02:00
Atlinx
8e7bcc2ee0 Add missing parameters for signal in docs
(cherry picked from commit 0e3097c023fa4562d44fa102bd2ef8e456f8901a)
2022-09-16 22:39:23 +02:00
Kongfa Waroros
1f3b5fde4e Update all AnimationTree's editors when editing
(cherry picked from commit 0f17fe642c8ec21b7877cd3f6911f22ba0874255)
2022-09-16 22:35:12 +02:00
bruvzg
1fce7ff540 Fix generation of duplicate locale property list files. 2022-09-16 22:34:51 +02:00
Atlinx
561aab3227 Remove HDR warning if on low end 2022-09-16 22:34:05 +02:00
kobewi
8474965b10 Hide prefix/suffix on SpinBox focus 2022-09-16 22:33:27 +02:00
Max Hilbrunner
637d36ccff Update UPnP documentation
Adds more details, especially about caveats, failure modes and pitfalls

(cherry picked from commit be41c097691acfd3f5559a28262730f086c46845)
2022-09-16 22:32:58 +02:00
Max Hilbrunner
b343e5758c UPNP: Don't delete mappings when adding mappings
Don't delete previous mappings when adding a new mapping.
This was a old workaround that seems to cause issues.

(cherry picked from commit 2685cc7bb6708df745317fd2f078bc945555e4f8)
2022-09-16 22:32:19 +02:00
Rémi Verschelde
d4e240f487 Linux: Fix GNU ld detection for pck_embed linker script
(cherry picked from commit fce3602a1e892cbc35fb3aa409bdae835a37be4f)
2022-09-16 22:31:50 +02:00
Pedro J. Estébanez
c91198b335 Add FileAccess::get_access_type()
(cherry picked from commit 8c6b2fbb908261d29a6692dd7a816464c28520d2)
2022-09-16 22:13:21 +02:00
dbcca5d26d Ported: Optimize String.repeat()
This backports the optimization done in `master`.
- Calinou, MewPurPur
3b31ff9008
2022-09-16 22:08:51 +02:00
Michael Alexsander
bce30062a5 Fix some corner cases in the Menu/OptionButton item auto-highlight 2022-09-16 22:04:23 +02:00
Michael Alexsander
7fd1e3b8ac Fix crash when pressing up on an empty PopupMenu 2022-09-16 22:01:53 +02:00
92bc8ed3be Ported: Fix header guard in error_macros.h - madmiraal
e2dac6ecd9
2022-09-16 22:01:08 +02:00
Yuri Sizov
211cd1e46a Remove Inspector tooltip hack that never actually worked 2022-09-16 21:57:00 +02:00
dec36df719 Fix compile. 2022-09-16 21:55:48 +02:00
Pedro J. Estébanez
d4555e520f Determine ProjectSettings' resource path early 2022-09-16 21:53:28 +02:00
Hugo Locurcio
34cda4b11b Add a [kbd] tag for highlighting keyboard shortcuts in the editor help
This allows backporting documentation from the `master` branch more easily,
as it already features the `[kbd]` tag.

Co-authored-by: Yuri Sizov <11782833+YuriSizov@users.noreply.github.com>
2022-09-16 21:49:06 +02:00
Hugo Locurcio
ddba4438ae Remove unused Create Signal Callbacks editor setting
This setting wasn't referred to anywhere.
2022-09-16 21:46:58 +02:00
bruvzg
11cebc25fa Use clang as assembler to ensure preprocessing is done, and add assembler "target" flag.
(cherry picked from commit e87377856174075e38b6d2ca338f28ffa0d9f59f)
2022-09-16 21:44:01 +02:00
bruvzg
b7d732b782 Add arch flag to assembler to fix build on ARM64 macOS / iOS.
(cherry picked from commit b767d2e0fdf835dc181bb21c8be69a35671b60b8)
2022-09-16 21:41:56 +02:00
a9eb3a52a3 Ported: zstd: Update to upstream version 1.5.2
Release notes:
- https://github.com/facebook/zstd/releases/tag/v1.5.1
- https://github.com/facebook/zstd/releases/tag/v1.5.2
-akien-mga
bda382684f
2022-09-16 21:31:55 +02:00