Relintai/sdl2_frt
1
0
Fork 0
mirror of https://github.com/Relintai/sdl2_frt.git synced 2024-12-16 11:06:49 +01:00
Code Issues Packages Projects Releases Wiki Activity
718e1fb8b1
sdl2_frt/include
History
Sam Lantinga 7c0986fba4 Fixed bug 4938 - Suggestion: rename SDL_PIXELFORMAT_BGR888 to SDL_PIXELFORMAT_XBGR8888 
Ellie

I just tripped over this: stb_image when requesting 3 channels with 8-bit actually returns them as 3 bytes per pixel with no alignment, so basically 4 pixels are 12 bytes with no padding (0...2, 3...5, 6...8, and 9...11). This I would have naively expected to be called RGB888 or BGR888, since there is no "dead" unused byte as I would expect for something called e.g. RGBX8888.

However, SDL2's SDL_PIXELFORMAT_BGR888 uses 4 bytes, same as SDL_PIXELFORMAT_BGRX8888, even though the latter appears to be a longer storage format - which it isn't, internally. It's just swapped, in byte order X, B, G, R (instead of BGRX). So why isn't the macro name also swapped, as "XBGR888" instead of just "BGR888"?

I find the formats therefore named inconsistently, and unless there is a reason for this I suggest these changes:

1. deprecate SDL_PIXELFORMAT_BGR888 in favor of a new SDL_PIXELFORMAT_XBGR8888

and

2. deprecate SDL_PIXELFORMAT_RGB888 in favor of a new SDL_PIXELFORMAT_XRGB8888
2020-06-12 10:30:46 -07:00
..
begin_code.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
close_code.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_assert.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_atomic.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_audio.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_bits.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_blendmode.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_clipboard.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_config_android.h Enable the virtual joystick API by default 2020-04-13 08:18:16 -07:00
SDL_config_iphoneos.h Fixed bug 4299 - A recent change requires Core Bluetooth framework on iOS 2020-04-14 07:41:00 -07:00
SDL_config_macosx.h Enable the virtual joystick API by default 2020-04-13 08:18:16 -07:00
SDL_config_minimal.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_config_os2.h Enable the virtual joystick API by default 2020-04-13 08:18:16 -07:00
SDL_config_pandora.h Enable the virtual joystick API by default 2020-04-13 08:18:16 -07:00
SDL_config_psp.h Enable the virtual joystick API by default 2020-04-13 08:18:16 -07:00
SDL_config_windows.h Fixed build on older Visual Studio, enable new features on newer Visual Studio 2020-04-22 15:42:32 -07:00
SDL_config_winrt.h Enable the virtual joystick API by default 2020-04-13 08:18:16 -07:00
SDL_config_wiz.h Enable the virtual joystick API by default 2020-04-13 08:18:16 -07:00
SDL_config.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_config.h.cmake Fixed bug 5103 - Port fcitx support to both fcitx 4 & 5 2020-05-11 14:31:04 -07:00
SDL_config.h.in Fixed bug 5103 - Port fcitx support to both fcitx 4 & 5 2020-05-11 14:31:04 -07:00
SDL_copying.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_cpuinfo.h Add SDL_SIMDRealloc 2020-06-11 12:03:33 -04:00
SDL_egl.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_endian.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_error.h Added SDL_GetErrorMsg() to get the error message in a thread-safe way 2020-03-13 21:28:09 -07:00
SDL_events.h locale: Implemented SDL_GetPreferredLocales(). 2020-05-04 02:27:29 -04:00
SDL_filesystem.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_gamecontroller.h Fixed bug 5028 - Virtual Joysticks (new joystick backend) 2020-03-13 19:08:45 -07:00
SDL_gesture.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_haptic.h Improvement for bug 3446 - The haptic API does not allow to select the direction axes 2020-05-04 13:17:43 -07:00
SDL_hints.h Make some changes to SDL_SetThreadPriority to try and have SDL transparently handle more of the work. 2020-05-26 13:19:19 -07:00
SDL_joystick.h virtual joysticks: improved docs for SDL_JoystickSetVirtual* functions 2020-03-15 13:35:03 -04:00
SDL_keyboard.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_keycode.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_loadso.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_locale.h locale: Implemented SDL_GetPreferredLocales(). 2020-05-04 02:27:29 -04:00
SDL_log.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_main.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_messagebox.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_metal.h metal: Added some support interfaces to Apple's Metal API (thanks, Caleb!). 2020-04-10 00:37:35 -04:00
SDL_mouse.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_mutex.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_name.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_opengl_glext.h Don't have Windows headers define min/max, in case they're defined by application code 2019-09-11 15:08:37 -07:00
SDL_opengl.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_opengles2_gl2.h
SDL_opengles2_gl2ext.h
SDL_opengles2_gl2platform.h
SDL_opengles2_khrplatform.h
SDL_opengles2.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_opengles.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_pixels.h Fixed bug 4938 - Suggestion: rename SDL_PIXELFORMAT_BGR888 to SDL_PIXELFORMAT_XBGR8888 2020-06-12 10:30:46 -07:00
SDL_platform.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_power.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_quit.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_rect.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_render.h Clarified that the clip rectangle is defined relative to the viewport, and added a clip test to testviewport.c 2020-03-08 21:02:40 -07:00
SDL_revision.h revert files I didnt mean to commit! 2017-09-29 10:15:44 -07:00
SDL_rwops.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_scancode.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_sensor.h First pass at Windows sensor implementation 2020-04-08 08:34:27 -07:00
SDL_shape.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_stdinc.h stdlib: Add SDL_trunc and SDL_truncf 2020-04-10 12:17:14 -04:00
SDL_surface.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_system.h Made SDL_GetAndroidSDKVersion() available for applications 2020-02-17 13:54:45 -08:00
SDL_syswm.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_test_assert.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_test_common.h test: Reimplemented SDLTest_CommonUsage() to restore binary compatibility. 2020-02-12 13:09:38 -05:00
SDL_test_compare.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_test_crc32.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_test_font.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_test_fuzzer.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_test_harness.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_test_images.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_test_log.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_test_md5.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_test_memory.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_test_random.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_test.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_thread.h Make some changes to SDL_SetThreadPriority to try and have SDL transparently handle more of the work. 2020-05-26 13:19:19 -07:00
SDL_timer.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_touch.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_types.h Updated copyright date for 2020 2020-01-16 20:49:25 -08:00
SDL_version.h Backed out changeset 51622f74dc85 2020-03-10 18:35:31 -07:00
SDL_video.h metal: Added some support interfaces to Apple's Metal API (thanks, Caleb!). 2020-04-10 00:37:35 -04:00
SDL_vulkan.h Fixed whitespace in SDL_vulkan.h 2020-06-02 16:59:54 -07:00
SDL.h locale: Implemented SDL_GetPreferredLocales(). 2020-05-04 02:27:29 -04:00