sdl2_frt/src/video
Sam Lantinga 177f19aff0 Fixed bug 3410 - SDL_WINDOW_HIDDEN flag is inaccurate.
Jason Wyatt

After hiding the window, SDL_WINDOW_HIDDEN/SDL_WINDOW_SHOWN flags on a window are correctly updated. However on the next SDL_PumpEvents, they are set incorrectly.

This appears to be because X11_GetNetWMState does not check whether the _NET_WM_STATE property exists (it shouldn't on unmapped windows, see https://specifications.freedesktop.org/wm-spec/wm-spec-1.3.html#idm140130317598336). This results in an empty list of atoms for the state, which would imply that the window is not hidden.

(Seen on Fedora 24, Gnome)

--

Dan Ginsburg

More details on my proposed patch: I am on Kubuntu 16.04.2.  I ran into this same bug, but with Jason's patch I found that actualType != None was true so the SDL_WINDOW_HIDDEN would still not be set.  My fix instead is to explicitly check for whether the window is unmapped rather than relying on the returned values in XGetWindowProperty.
2017-07-20 10:52:43 -07:00
..
android Fixed bug 3703 - Missing media keys support on Amazon Fire TV remote control 2017-07-20 10:46:38 -07:00
cocoa macOS: Fix compilation when using 10.11 or earlier to build. 2017-07-14 17:42:11 -03:00
directfb directfb: Fixed quitting keyboard twice. 2017-06-16 23:30:30 +02:00
dummy Updated copyright for 2017 2017-01-01 18:33:28 -08:00
emscripten emscripten: listen for pointerlockchange events on the #document specifically. 2017-06-05 21:30:25 -04:00
haiku haiku: Fixed compiling without OpenGL support. 2017-07-07 23:00:22 +02:00
mir Removed redundant mouse clean up on quit for some platforms. 2017-05-19 23:30:59 +02:00
nacl nacl: Fixed unnecessary large input text array. 2017-06-16 23:30:13 +02:00
pandora pandora: Fixed compile error. 2017-06-16 23:30:38 +02:00
psp Fixed SDL_GetWindowWMInfo() returning success on three unsupported platforms. 2017-06-15 23:30:29 +02:00
qnx qnx: fixed potential buffer overflow. 2017-07-01 19:52:12 -04:00
raspberry Fixed SDL_GetWindowWMInfo() returning success on three unsupported platforms. 2017-06-15 23:30:29 +02:00
uikit iOS: Use modern replacements for deprecated functions, when available. 2017-07-15 17:41:58 -03:00
vivante Removed newlines from error messages. 2017-03-26 21:00:19 +02:00
wayland Fixed missing error messages for SDL_GetWindowWMInfo(). 2017-06-11 22:30:39 +02:00
windows Get the parent of non-SDL-created windows, for completeness 2017-06-16 11:14:08 -07:00
winrt winrt: Fixed SDL include. 2017-06-24 23:45:44 +02:00
x11 Fixed bug 3410 - SDL_WINDOW_HIDDEN flag is inaccurate. 2017-07-20 10:52:43 -07:00
SDL_blit_0.c Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_blit_1.c Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_blit_A.c Fix some more compiler warnings on armcc. 2017-03-03 16:38:17 -05:00
SDL_blit_auto.c Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_blit_auto.h Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_blit_copy.c Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_blit_copy.h Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_blit_N.c Fixed comment style. 2017-02-26 21:20:39 +01:00
SDL_blit_slow.c Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_blit_slow.h Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_blit.c Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_blit.h Really fixed blit issue for capehill 2017-01-07 16:51:48 -08:00
SDL_bmp.c Fix some more compiler warnings on armcc. 2017-03-03 16:38:17 -05:00
SDL_clipboard.c Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_egl_c.h Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_egl.c Fixed warning in Android build 2017-02-10 09:41:16 -08:00
SDL_fillrect.c Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_pixels_c.h Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_pixels.c Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_rect_c.h Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_rect.c Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_RLEaccel_c.h Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_RLEaccel.c Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_shape_internals.h Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_shape.c Fixed bug 3699 - Shaped windows are distorted unless width is divisible by 8 2017-07-11 08:16:00 -07:00
SDL_stretch.c Removed newlines from error messages. 2017-03-26 21:00:19 +02:00
SDL_surface.c Updated copyright for 2017 2017-01-01 18:33:28 -08:00
SDL_sysvideo.h iOS: Use modern replacements for deprecated functions, when available. 2017-07-15 17:41:58 -03:00
SDL_video.c iOS: Use modern replacements for deprecated functions, when available. 2017-07-15 17:41:58 -03:00
sdlgenblit.pl Updated copyright for 2017 2017-01-01 18:33:28 -08:00