From aa3a409b057a8559dfc0c06307c71e351d3bfda1 Mon Sep 17 00:00:00 2001 From: "Yann E. MORIN" Date: Mon, 6 Apr 2015 14:13:06 +0200 Subject: [PATCH] support/download: do not warn about missing hash file for repositories When downloading from a repository, we explicitly pass no hash file, because we can't check hashes in that case. However, we're still printing a message that there is a missign hash file. Beside being a bit annoying (since we can't do anything about it), it may also be wrong, especially for packages for which we support multiple versions, with some being downloaded via a git clone and others as tarballs. Just print no warning when the path to the hash file is empty. Signed-off-by: "Yann E. MORIN" Cc: Thomas Petazzoni Cc: Gustavo Zacarias Reviewed-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Thomas Petazzoni --- support/download/check-hash | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/support/download/check-hash b/support/download/check-hash index 67c1780112..d37f1cdf52 100755 --- a/support/download/check-hash +++ b/support/download/check-hash @@ -31,8 +31,12 @@ h_file="${1}" file="${2}" base="${3}" +# Bail early if no hash to check +if [ -z "${h_file}" ]; then + exit 0 +fi # Does the hash-file exist? -if [ -z "${h_file}" -o ! -f "${h_file}" ]; then +if [ ! -f "${h_file}" ]; then printf "WARNING: no hash file for %s\n" "${base}" >&2 exit 0 fi