Relintai/sdl2_frt
1
0
Fork 0
mirror of https://github.com/Relintai/sdl2_frt.git synced 2024-12-16 11:06:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix use-after-free when pumping the event loop after SDL_DestroyWindow()

Browse Source 
Closing the window is asynchronous, but we free the window data immediately,
so we can get an updateLayer callback before the window is really destroyed which
will cause us to access the freed memory.

Clearing the content view will cause it to be immediately released, so no further
updateLayer callbacks will occur.
This commit is contained in:
Cameron Gutman 2019-04-28 17:37:49 -07:00
parent a4e33b9cc4
commit 9b2202828a
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/video/cocoa/SDL_cocoawindow.m
View File

@ -1816,6 +1816,8 @@ Cocoa_DestroyWindow(_THIS, SDL_Window * window)
[data->listener close]; [data->listener close];
[data->listener release]; [data->listener release];
if (data->created) { if (data->created) {
/* Release the content view to avoid further updateLayer callbacks */
[data->nswindow setContentView:nil];
[data->nswindow close]; [data->nswindow close];
} }