From 8414c3d4ae45f1122769a2e11775ced95ecd3092 Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Sun, 11 Dec 2016 12:01:44 -0800 Subject: [PATCH] Fixed ABI, don't change the return type of SDL_GL_SwapWindow() --- include/SDL_video.h | 2 +- src/dynapi/SDL_dynapi_procs.h | 2 +- src/video/SDL_video.c | 12 +++++++----- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/include/SDL_video.h b/include/SDL_video.h index d116ef612..402ff1c21 100644 --- a/include/SDL_video.h +++ b/include/SDL_video.h @@ -1195,7 +1195,7 @@ extern DECLSPEC int SDLCALL SDL_GL_GetSwapInterval(void); * \brief Swap the OpenGL buffers for a window, if double-buffering is * supported. */ -extern DECLSPEC int SDLCALL SDL_GL_SwapWindow(SDL_Window * window); +extern DECLSPEC void SDLCALL SDL_GL_SwapWindow(SDL_Window * window); /** * \brief Delete an OpenGL context. diff --git a/src/dynapi/SDL_dynapi_procs.h b/src/dynapi/SDL_dynapi_procs.h index 132d8c2b4..ea1f6b2f5 100644 --- a/src/dynapi/SDL_dynapi_procs.h +++ b/src/dynapi/SDL_dynapi_procs.h @@ -595,7 +595,7 @@ SDL_DYNAPI_PROC(SDL_GLContext,SDL_GL_GetCurrentContext,(void),(),return) SDL_DYNAPI_PROC(void,SDL_GL_GetDrawableSize,(SDL_Window *a, int *b, int *c),(a,b,c),) SDL_DYNAPI_PROC(int,SDL_GL_SetSwapInterval,(int a),(a),return) SDL_DYNAPI_PROC(int,SDL_GL_GetSwapInterval,(void),(),return) -SDL_DYNAPI_PROC(int,SDL_GL_SwapWindow,(SDL_Window *a),(a),return) +SDL_DYNAPI_PROC(void,SDL_GL_SwapWindow,(SDL_Window *a),(a),return) SDL_DYNAPI_PROC(void,SDL_GL_DeleteContext,(SDL_GLContext a),(a),) SDL_DYNAPI_PROC(int,SDL_vsscanf,(const char *a, const char *b, va_list c),(a,b,c),return) SDL_DYNAPI_PROC(int,SDL_GameControllerAddMappingsFromRW,(SDL_RWops *a, int b),(a,b),return) diff --git a/src/video/SDL_video.c b/src/video/SDL_video.c index 230a3f49f..508aed901 100644 --- a/src/video/SDL_video.c +++ b/src/video/SDL_video.c @@ -3390,20 +3390,22 @@ SDL_GL_GetSwapInterval(void) } } -int +void SDL_GL_SwapWindow(SDL_Window * window) { - CHECK_WINDOW_MAGIC(window,-1); + CHECK_WINDOW_MAGIC(window,); if (!(window->flags & SDL_WINDOW_OPENGL)) { - return SDL_SetError("The specified window isn't an OpenGL window"); + SDL_SetError("The specified window isn't an OpenGL window"); + return; } if (SDL_GL_GetCurrentWindow() != window) { - return SDL_SetError("The specified window has not been made current"); + SDL_SetError("The specified window has not been made current"); + return; } - return _this->GL_SwapWindow(_this, window); + _this->GL_SwapWindow(_this, window); } void