Relintai/sdl2_frt
1
0
Fork 0
mirror of https://github.com/Relintai/sdl2_frt.git synced 2024-12-16 11:06:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixed bug 3545 - SDL_EVDEV_do_text_input() may be too eager to find error cases

Browse Source 
Rob

I've ran into an issue where I successfully receive SDL_KEY[UP,DOWN] events but not SDL_TEXTINPUT or SDL_TEXTEDITING.  In my case the code in SDL_EVDEV_do_text_input() is returning early (on error) prior to calling SDL_SendKeyboardText().  I'm running on the RaspberryPi 3, without X11.

In SDL_EVDEV_do_text_input() there is a condition to check keysyms with a type value below 0xf0, then subtract 0xf0 from type.  Without understanding the purpose of this code, I disabled it, recompiled, and I'm getting correct SDL_TEXTINPUT events.  I'm going to guess that my hack/fix is going to be problematic in some other environment, but after some initial testing it looks like everything is running fine in my setup.
This commit is contained in:
Sam Lantinga 2017-01-08 20:03:18 -08:00
parent 7b66295e05
commit 49292705a9
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/linux/SDL_evdev.c
View File

@ -289,6 +289,12 @@ static void SDL_EVDEV_do_text_input(unsigned short keycode)
return; return;
} }
if (kbe.kb_value == K_HOLE || kbe.kb_value == K_NOSUCHMAP) {
return;
}
kbe.kb_value ^= 0xf000;
type = KTYP(kbe.kb_value); type = KTYP(kbe.kb_value);
if (type < 0xf0) { if (type < 0xf0) {