2017-08-02 19:22:48 +02:00
|
|
|
/*
|
|
|
|
Simple DirectMedia Layer
|
2020-01-17 05:49:25 +01:00
|
|
|
Copyright (C) 1997-2020 Sam Lantinga <slouken@libsdl.org>
|
2017-08-02 19:22:48 +02:00
|
|
|
|
|
|
|
This software is provided 'as-is', without any express or implied
|
|
|
|
warranty. In no event will the authors be held liable for any damages
|
|
|
|
arising from the use of this software.
|
|
|
|
|
|
|
|
Permission is granted to anyone to use this software for any purpose,
|
|
|
|
including commercial applications, and to alter it and redistribute it
|
|
|
|
freely, subject to the following restrictions:
|
|
|
|
|
|
|
|
1. The origin of this software must not be misrepresented; you must not
|
|
|
|
claim that you wrote the original software. If you use this software
|
|
|
|
in a product, an acknowledgment in the product documentation would be
|
|
|
|
appreciated but is not required.
|
|
|
|
2. Altered source versions must be plainly marked as such, and must not be
|
|
|
|
misrepresented as being the original software.
|
|
|
|
3. This notice may not be removed or altered from any source distribution.
|
|
|
|
*/
|
2017-08-22 02:20:50 +02:00
|
|
|
|
2017-08-02 19:22:48 +02:00
|
|
|
#include "../../SDL_internal.h"
|
|
|
|
|
|
|
|
#if SDL_VIDEO_DRIVER_KMSDRM && SDL_VIDEO_OPENGL_EGL
|
|
|
|
|
|
|
|
#include "SDL_kmsdrmvideo.h"
|
|
|
|
#include "SDL_kmsdrmopengles.h"
|
|
|
|
#include "SDL_kmsdrmdyn.h"
|
|
|
|
|
|
|
|
#ifndef EGL_PLATFORM_GBM_MESA
|
|
|
|
#define EGL_PLATFORM_GBM_MESA 0x31D7
|
|
|
|
#endif
|
|
|
|
|
|
|
|
/* EGL implementation of SDL OpenGL support */
|
|
|
|
|
|
|
|
int
|
|
|
|
KMSDRM_GLES_LoadLibrary(_THIS, const char *path) {
|
2020-07-20 11:42:23 +02:00
|
|
|
NativeDisplayType display = (NativeDisplayType)((SDL_VideoData *)_this->driverdata)->gbm_dev;
|
2020-02-27 17:20:34 +01:00
|
|
|
return SDL_EGL_LoadLibrary(_this, path, display, EGL_PLATFORM_GBM_MESA);
|
2017-08-02 19:22:48 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
SDL_EGL_CreateContext_impl(KMSDRM)
|
|
|
|
|
|
|
|
int KMSDRM_GLES_SetSwapInterval(_THIS, int interval) {
|
|
|
|
if (!_this->egl_data) {
|
|
|
|
return SDL_SetError("EGL not initialized");
|
|
|
|
}
|
|
|
|
|
|
|
|
if (interval == 0 || interval == 1) {
|
|
|
|
_this->egl_data->egl_swapinterval = interval;
|
|
|
|
} else {
|
|
|
|
return SDL_SetError("Only swap intervals of 0 or 1 are supported");
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-07-28 21:11:25 +02:00
|
|
|
/*********************************/
|
|
|
|
/* Atomic functions block */
|
|
|
|
/*********************************/
|
|
|
|
|
|
|
|
#define VOID2U64(x) ((uint64_t)(unsigned long)(x))
|
|
|
|
|
|
|
|
static EGLSyncKHR create_fence(int fd, _THIS)
|
|
|
|
{
|
|
|
|
EGLint attrib_list[] = {
|
|
|
|
EGL_SYNC_NATIVE_FENCE_FD_ANDROID, fd,
|
|
|
|
EGL_NONE,
|
|
|
|
};
|
|
|
|
EGLSyncKHR fence = _this->egl_data->eglCreateSyncKHR(_this->egl_data->egl_display,
|
|
|
|
EGL_SYNC_NATIVE_FENCE_ANDROID, attrib_list);
|
|
|
|
assert(fence);
|
|
|
|
return fence;
|
|
|
|
}
|
|
|
|
|
2017-08-02 19:22:48 +02:00
|
|
|
int
|
|
|
|
KMSDRM_GLES_SwapWindow(_THIS, SDL_Window * window) {
|
2020-07-28 21:11:25 +02:00
|
|
|
|
2020-02-09 20:44:22 +01:00
|
|
|
SDL_WindowData *windata = ((SDL_WindowData *) window->driverdata);
|
|
|
|
SDL_DisplayData *dispdata = (SDL_DisplayData *) SDL_GetDisplayForWindow(window)->driverdata;
|
2020-07-28 21:11:25 +02:00
|
|
|
KMSDRM_FBInfo *fb;
|
Fixed bug 5140 - KMSDRM: Dynamic vsync toggle does not work
Manuel Alfayate Corchete
The KMSDRM backend was doing things wrong because of some small (but important) misconceptions on how KMS/DRM works: to implement a largely broken non-vsync refresh mechanism, the SwapWindow() function was issuing new pageflips before previous ones had completed, thus causing EBUSY returns, buffer mismanagement, etc... resulting in general breakage on vsync disabling from apps, that would not allow vsync to work again without KMSDRM video re-initialization.
To further clarify, on most DRM drivers async pageflips are NOT working nowadays, so all issued pageflips will complete on next VBLANK, NOT ASAP (calling drmModePageFlip() with the DRM_MODE_PAGE_FLIP_ASYNC flag will return error).
The old code was assuming that can just issue a synchronous (=on VBLANK) pageflip and then pass a 0 timeout to the pull() function so we do not wait for the pageflip event, thinking that this will lead to correct non-vsynced screen updates from the program: That is plain wrong.
Each pageflip has to be waite before issuing a new one, ALWAYS. And if we do not support ASYNC pageflips on the DRM driver level, then we are forced to wait for the next VBLANK. There is no way around it.
I have also added many comments on the KMSDRM code. This is needed for future reference for me or others who may need to look at this code: KMS/DRM terminology regarding what SYNC and ASYNC mean in pageflip terms, and where to do certain things and why, is not trivial. It is not desirable or possible to invest time on researching the same concepts every time there is need to dive into this code. So please leave all these comments in the patch.
2020-05-27 01:27:00 +02:00
|
|
|
|
2020-08-01 18:23:34 +02:00
|
|
|
EGLint status;
|
|
|
|
int ret;
|
|
|
|
|
2020-07-28 21:11:25 +02:00
|
|
|
uint32_t flags = DRM_MODE_ATOMIC_NONBLOCK;
|
Fixed bug 5140 - KMSDRM: Dynamic vsync toggle does not work
Manuel Alfayate Corchete
The KMSDRM backend was doing things wrong because of some small (but important) misconceptions on how KMS/DRM works: to implement a largely broken non-vsync refresh mechanism, the SwapWindow() function was issuing new pageflips before previous ones had completed, thus causing EBUSY returns, buffer mismanagement, etc... resulting in general breakage on vsync disabling from apps, that would not allow vsync to work again without KMSDRM video re-initialization.
To further clarify, on most DRM drivers async pageflips are NOT working nowadays, so all issued pageflips will complete on next VBLANK, NOT ASAP (calling drmModePageFlip() with the DRM_MODE_PAGE_FLIP_ASYNC flag will return error).
The old code was assuming that can just issue a synchronous (=on VBLANK) pageflip and then pass a 0 timeout to the pull() function so we do not wait for the pageflip event, thinking that this will lead to correct non-vsynced screen updates from the program: That is plain wrong.
Each pageflip has to be waite before issuing a new one, ALWAYS. And if we do not support ASYNC pageflips on the DRM driver level, then we are forced to wait for the next VBLANK. There is no way around it.
I have also added many comments on the KMSDRM code. This is needed for future reference for me or others who may need to look at this code: KMS/DRM terminology regarding what SYNC and ASYNC mean in pageflip terms, and where to do certain things and why, is not trivial. It is not desirable or possible to invest time on researching the same concepts every time there is need to dive into this code. So please leave all these comments in the patch.
2020-05-27 01:27:00 +02:00
|
|
|
|
2020-08-01 18:23:34 +02:00
|
|
|
EGLSyncKHR display_in_fence = NULL;
|
|
|
|
EGLSyncKHR display_out_fence = NULL;
|
|
|
|
|
|
|
|
/* Create the display in-fence, and export it as a fence fd to pass into the kernel. */
|
|
|
|
display_in_fence = create_fence(EGL_NO_NATIVE_FENCE_FD_ANDROID, _this);
|
|
|
|
assert(display_in_fence);
|
|
|
|
dispdata->kms_in_fence_fd = _this->egl_data->eglDupNativeFenceFDANDROID(_this->egl_data->egl_display, display_in_fence);
|
|
|
|
|
|
|
|
/* Mark the back buffer as the next front buffer, and the current front buffer as elegible
|
|
|
|
by EGL as back buffer to draw into.
|
|
|
|
This will not really happen until we post the pageflip though KMS with the atomic ioctl
|
|
|
|
and it completes on next vsync. */
|
2020-07-28 21:11:25 +02:00
|
|
|
_this->egl_data->eglSwapBuffers(_this->egl_data->egl_display, windata->egl_surface);
|
|
|
|
|
2020-08-01 18:23:34 +02:00
|
|
|
/* Lock the buffer that is marked by eglSwapBuffers() to become the next front buffer (so it can not
|
|
|
|
be chosen by EGL as back buffer to draw on), and get a handle to it, so we can use that handle
|
|
|
|
to request the KMS pageflip that will set it as front buffer. */
|
2020-07-28 21:11:25 +02:00
|
|
|
windata->next_bo = KMSDRM_gbm_surface_lock_front_buffer(windata->gs);
|
|
|
|
if (!windata->next_bo) {
|
|
|
|
printf("Failed to lock frontbuffer\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
fb = KMSDRM_FBFromBO(_this, windata->next_bo);
|
|
|
|
if (!fb) {
|
|
|
|
printf("Failed to get a new framebuffer BO\n");
|
|
|
|
return -1;
|
2017-08-02 19:22:48 +02:00
|
|
|
}
|
|
|
|
|
2020-08-01 18:23:34 +02:00
|
|
|
/*
|
|
|
|
* Issue atomic pageflip to post the pageflip thru KMS. Returns immediately.
|
|
|
|
* Never issue an atomic ioctl while the previuos one is pending: it will be rejected.
|
2020-07-28 21:11:25 +02:00
|
|
|
*/
|
|
|
|
ret = drm_atomic_commit(_this, fb->fb_id, flags);
|
|
|
|
if (ret) {
|
|
|
|
printf("failed to do atomic commit\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2020-08-01 18:23:34 +02:00
|
|
|
/* Get the display out fence, returned by the atomic ioctl. */
|
|
|
|
display_out_fence = create_fence(dispdata->kms_out_fence_fd, _this);
|
|
|
|
assert(display_out_fence);
|
|
|
|
|
|
|
|
/* Wait on the CPU side for the _previous_ commit to complete before we post the flip through KMS,
|
|
|
|
* because atomic will reject the commit if we post a new one while the previous one is still pending. */
|
|
|
|
do {
|
|
|
|
status = _this->egl_data->eglClientWaitSyncKHR(_this->egl_data->egl_display, display_out_fence, 0, EGL_FOREVER_KHR);
|
|
|
|
} while (status != EGL_CONDITION_SATISFIED_KHR);
|
|
|
|
|
|
|
|
/* Destroy both in and out display fences. */
|
|
|
|
_this->egl_data->eglDestroySyncKHR(_this->egl_data->egl_display, display_out_fence);
|
|
|
|
_this->egl_data->eglDestroySyncKHR(_this->egl_data->egl_display, display_in_fence);
|
|
|
|
|
|
|
|
/* Now that the pageflip is complete, release last front buffer so EGL can chose it
|
|
|
|
* as back buffer and render on it again: */
|
2020-07-28 21:11:25 +02:00
|
|
|
if (windata->curr_bo) {
|
|
|
|
KMSDRM_gbm_surface_release_buffer(windata->gs, windata->curr_bo);
|
|
|
|
windata->curr_bo = NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Take note of the current front buffer, so it can be freed next time this function is called. */
|
|
|
|
windata->curr_bo = windata->next_bo;
|
|
|
|
|
|
|
|
return ret;
|
2017-08-02 19:22:48 +02:00
|
|
|
}
|
|
|
|
|
2020-07-28 21:11:25 +02:00
|
|
|
/***************************************/
|
|
|
|
/* End of Atomic functions block */
|
|
|
|
/***************************************/
|
|
|
|
|
2017-08-02 19:22:48 +02:00
|
|
|
SDL_EGL_MakeCurrent_impl(KMSDRM)
|
|
|
|
|
|
|
|
#endif /* SDL_VIDEO_DRIVER_KMSDRM && SDL_VIDEO_OPENGL_EGL */
|
|
|
|
|
|
|
|
/* vi: set ts=4 sw=4 expandtab: */
|