From b7d07a44873f91cec4f3e3ca202c98a838d30363 Mon Sep 17 00:00:00 2001 From: Relintai Date: Fri, 29 Jul 2022 10:17:20 +0200 Subject: [PATCH] Ported: Tweak default crash handler message in exported projects When an exported project crashes, the crash handler message shouldn't reference the Godot issue tracker, as not all crashes are Godot's fault. Reporting crashes that only occur on exported projects is still allowed, but it should not be done by people who aren't working on the project in question. - Calinou https://github.com/godotengine/godot/commit/bec892c010a18d15a7b6cc28a7857d1e5edfd8d3 --- doc/classes/ProjectSettings.xml | 7 +++++-- main/main.cpp | 3 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/doc/classes/ProjectSettings.xml b/doc/classes/ProjectSettings.xml index d23a37eab..f465d7edd 100644 --- a/doc/classes/ProjectSettings.xml +++ b/doc/classes/ProjectSettings.xml @@ -406,8 +406,11 @@ If [code]true[/code], enables warnings when assigning the result of a function that returns [code]void[/code] to a variable. - - Message to be displayed before the backtrace when the engine crashes. + + Message to be displayed before the backtrace when the engine crashes. By default, this message is only used in exported projects due to the editor-only override applied to this setting. + + + Editor-only override for [member debug/settings/crash_handler/message]. Does not affect exported projects in debug or release mode. Maximum number of frames per second allowed. The actual number of frames per second may still be below this value if the game is lagging. See also [member physics/common/physics_ticks_per_second]. diff --git a/main/main.cpp b/main/main.cpp index 94c48be7d..fdb7d1277 100644 --- a/main/main.cpp +++ b/main/main.cpp @@ -405,7 +405,8 @@ Error Main::setup(const char *execpath, int argc, char *argv[], bool p_second_ph ClassDB::register_class(); engine->add_singleton(Engine::Singleton("Performance", performance)); - GLOBAL_DEF("debug/settings/crash_handler/message", String("Please include this when reporting the bug on https://github.com/Relintai/pandemonium_engine/issues")); + GLOBAL_DEF("debug/settings/crash_handler/message", String("Please include this when reporting the bug to the project developer.")); + GLOBAL_DEF("debug/settings/crash_handler/message.editor", String("Please include this when reporting the bug on: https://github.com/Relintai/pandemonium_engine/issues")); MAIN_PRINT("Main: Parse CMDLine");