Relintai/pandemonium_engine
1
0
Fork 0
mirror of https://github.com/Relintai/pandemonium_engine.git synced 2025-03-28 06:46:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Backported from godot4: Defer EditorInspector::update_tree to the process stage to improve performance

Browse Source 
`EditorInspector::update_tree` is expensive, so defer the call to the process phase
to prevent multiple calls in a single frame (when switching scene tabs).
- Rindbee
f352c30ad5
This commit is contained in:
Relintai 2024-03-08 16:12:21 +01:00
parent a44fb35ca1
commit b757336215
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
editor/editor_inspector.cpp
View File

@ -2249,7 +2249,7 @@ void EditorInspector::_parse_added_editors(VBoxContainer *current_vbox, Ref<Edit
ped->added_editors.clear(); ped->added_editors.clear();
} }
void EditorInspector::update_tree() { void EditorInspector::_update_tree() {
//to update properly if all is refreshed //to update properly if all is refreshed
StringName current_selected = property_selected; StringName current_selected = property_selected;
int current_focusable = -1; int current_focusable = -1;
@ -2786,6 +2786,11 @@ void EditorInspector::update_tree() {
_parse_added_editors(main_vbox, ped); _parse_added_editors(main_vbox, ped);
} }
} }
void EditorInspector::update_tree() {
update_tree_pending = true;
}
void EditorInspector::update_property(const String &p_prop) { void EditorInspector::update_property(const String &p_prop) {
if (!editor_property_map.has(p_prop)) { if (!editor_property_map.has(p_prop)) {
return; return;
@ -3021,7 +3026,7 @@ void EditorInspector::_edit_set(const String &p_name, const Variant &p_value, bo
} else { } else {
undo_redo->create_action(vformat(TTR("Set %s"), p_name), UndoRedo::MERGE_ENDS); undo_redo->create_action(vformat(TTR("Set %s"), p_name), UndoRedo::MERGE_ENDS);
undo_redo->add_do_property(object, p_name, p_value); undo_redo->add_do_property(object, p_name, p_value);
bool valid = false; bool valid = false;
Variant value = object->get(p_name, &valid); Variant value = object->get(p_name, &valid);
if (valid) { if (valid) {
@ -3261,10 +3266,11 @@ void EditorInspector::_notification(int p_what) {
changing++; changing++;
if (update_tree_pending) { if (update_tree_pending) {
update_tree();
update_tree_pending = false; update_tree_pending = false;
pending.clear(); pending.clear();
_update_tree();
} else { } else {
while (pending.size()) { while (pending.size()) {
StringName prop = pending.front()->get(); StringName prop = pending.front()->get();

2
editor/editor_inspector.h
View File

@ -505,6 +505,8 @@ class EditorInspector : public ScrollContainer {
void _update_inspector_bg(); void _update_inspector_bg();
void _update_tree();
protected: protected:
static void _bind_methods(); static void _bind_methods();
void _notification(int p_what); void _notification(int p_what);