SCons: Remove redundant -fomit-frame-pointer and -ftree-vectorize

- `-fomit-frame-pointer` is included automatically by both GCC and
  Clang in `-O1` and above.
- `-ftree-vectorize` is included automatically by GCC in `-O2` and
  beyond, and seems always enabled by Clang.

Closes #66296. See that issue for a detailed investigation.

(cherry picked from commit c5c3d13dc0dbbf95a2350f57d69e7cdc546d395d)
This commit is contained in:
Rémi Verschelde 2022-09-23 13:55:00 +02:00 committed by Relintai
parent 6ebc813e48
commit 8be8577da6
3 changed files with 5 additions and 6 deletions

View File

@ -117,12 +117,11 @@ def configure(env):
# `-O2` is more friendly to debuggers than `-O3`, leading to better crash backtraces # `-O2` is more friendly to debuggers than `-O3`, leading to better crash backtraces
# when using `target=release_debug`. # when using `target=release_debug`.
opt = "-O3" if env["target"] == "release" else "-O2" opt = "-O3" if env["target"] == "release" else "-O2"
env.Append(CCFLAGS=[opt, "-fomit-frame-pointer"]) env.Append(CCFLAGS=[opt])
elif env["optimize"] == "size": # optimize for size elif env["optimize"] == "size": # optimize for size
env.Append(CCFLAGS=["-Oz"]) env.Append(CCFLAGS=["-Oz"])
env.Append(CPPDEFINES=["NDEBUG"]) env.Append(CPPDEFINES=["NDEBUG"])
env.Append(CCFLAGS=["-ftree-vectorize"])
elif env["target"] == "debug": elif env["target"] == "debug":
env.Append(LINKFLAGS=["-O0"]) env.Append(LINKFLAGS=["-O0"])
env.Append(CCFLAGS=["-O0", "-g", "-fno-limit-debug-info"]) env.Append(CCFLAGS=["-O0", "-g", "-fno-limit-debug-info"])

View File

@ -54,10 +54,10 @@ def configure(env):
# `-O2` is more friendly to debuggers than `-O3`, leading to better crash backtraces # `-O2` is more friendly to debuggers than `-O3`, leading to better crash backtraces
# when using `target=release_debug`. # when using `target=release_debug`.
opt = "-O3" if env["target"] == "release" else "-O2" opt = "-O3" if env["target"] == "release" else "-O2"
env.Append(CCFLAGS=[opt, "-ftree-vectorize", "-fomit-frame-pointer"]) env.Append(CCFLAGS=[opt])
env.Append(LINKFLAGS=[opt]) env.Append(LINKFLAGS=[opt])
elif env["optimize"] == "size": # optimize for size elif env["optimize"] == "size": # optimize for size
env.Append(CCFLAGS=["-Os", "-ftree-vectorize"]) env.Append(CCFLAGS=["-Os"])
env.Append(LINKFLAGS=["-Os"]) env.Append(LINKFLAGS=["-Os"])
elif env["target"] == "debug": elif env["target"] == "debug":

View File

@ -43,9 +43,9 @@ def configure(env):
if env["target"] == "release": if env["target"] == "release":
if env["optimize"] == "speed": # optimize for speed (default) if env["optimize"] == "speed": # optimize for speed (default)
env.Prepend(CCFLAGS=["-O3", "-fomit-frame-pointer", "-ftree-vectorize"]) env.Prepend(CCFLAGS=["-O3"])
elif env["optimize"] == "size": # optimize for size elif env["optimize"] == "size": # optimize for size
env.Prepend(CCFLAGS=["-Os", "-ftree-vectorize"]) env.Prepend(CCFLAGS=["-Os"])
if env["arch"] != "arm64": if env["arch"] != "arm64":
env.Prepend(CCFLAGS=["-msse2"]) env.Prepend(CCFLAGS=["-msse2"])