Relintai/pandemonium_engine
1
0
Fork 0
mirror of https://github.com/Relintai/pandemonium_engine.git synced 2025-03-28 14:56:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Mark the parameters of Basis::rotate_to_align as const ref.

Browse Source
This commit is contained in:
Relintai 2023-05-29 13:03:26 +02:00
parent 9e326c3000
commit 47e637b2b8
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/math/basis.cpp
View File

@ -404,7 +404,7 @@ Quaternion Basis::get_rotation_quaternion() const {
return m.get_quaternion(); return m.get_quaternion();
} }
void Basis::rotate_to_align(Vector3 p_start_direction, Vector3 p_end_direction) { void Basis::rotate_to_align(const Vector3 &p_start_direction, const Vector3 &p_end_direction) {
// Takes two vectors and rotates the basis from the first vector to the second vector. // Takes two vectors and rotates the basis from the first vector to the second vector.
// Adopted from: https://gist.github.com/kevinmoran/b45980723e53edeb8a5a43c49f134724 // Adopted from: https://gist.github.com/kevinmoran/b45980723e53edeb8a5a43c49f134724
const Vector3 axis = p_start_direction.cross(p_end_direction).normalized(); const Vector3 axis = p_start_direction.cross(p_end_direction).normalized();

2
core/math/basis.h
View File

@ -81,7 +81,7 @@ struct _NO_DISCARD_CLASS_ Basis {
Quaternion get_rotation_quaternion() const; Quaternion get_rotation_quaternion() const;
Vector3 get_rotation() const { return get_rotation_euler(); }; Vector3 get_rotation() const { return get_rotation_euler(); };
void rotate_to_align(Vector3 p_start_direction, Vector3 p_end_direction); void rotate_to_align(const Vector3 &p_start_direction, const Vector3 &p_end_direction);
Vector3 rotref_posscale_decomposition(Basis &rotref) const; Vector3 rotref_posscale_decomposition(Basis &rotref) const;