Slider min value for a bipolar parameter should be -1

Fixes #1
This commit is contained in:
Haoyu Qiu 2022-07-24 23:44:34 +08:00
parent d9520c17c2
commit 7c82e81fdd
4 changed files with 19 additions and 3 deletions

View File

@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [Unreleased]
### Fixed
- Slider min value for a bipolar parameter should be -1.
## [1.1.0] - 2022-03-10
### Added

View File

@ -221,6 +221,7 @@ margin_right = 211.0
margin_bottom = 126.0
label = "Change Amount"
parameter = "p_arp_mod"
bipolar = true
[node name="ParamSlider6" parent="Editor/ScrollContainer/Params/Envolope" instance=ExtResource( 3 )]
margin_top = 130.0
@ -260,6 +261,7 @@ margin_right = 210.0
margin_bottom = 74.0
label = "Slide"
parameter = "p_freq_ramp"
bipolar = true
[node name="ParamSlider4" parent="Editor/ScrollContainer/Params/Frequency" instance=ExtResource( 3 )]
margin_top = 78.0
@ -267,6 +269,7 @@ margin_right = 210.0
margin_bottom = 100.0
label = "Delta Slide"
parameter = "p_freq_dramp"
bipolar = true
[node name="ParamSlider5" parent="Editor/ScrollContainer/Params/Frequency" instance=ExtResource( 3 )]
margin_top = 104.0
@ -313,6 +316,7 @@ margin_right = 220.0
margin_bottom = 74.0
label = "Duty Sweep"
parameter = "p_duty_ramp"
bipolar = true
[node name="ParamSlider5" parent="Editor/ScrollContainer/Params/Waveform" instance=ExtResource( 3 )]
margin_top = 78.0
@ -320,6 +324,7 @@ margin_right = 220.0
margin_bottom = 100.0
label = "Phaser Offset"
parameter = "p_pha_offset"
bipolar = true
[node name="ParamSlider3" parent="Editor/ScrollContainer/Params/Waveform" instance=ExtResource( 3 )]
margin_top = 104.0
@ -327,6 +332,7 @@ margin_right = 220.0
margin_bottom = 126.0
label = "Phaser Sweep"
parameter = "p_pha_ramp"
bipolar = true
[node name="Filter" type="VBoxContainer" parent="Editor/ScrollContainer/Params"]
margin_left = 653.0
@ -345,6 +351,7 @@ margin_right = 242.0
margin_bottom = 48.0
label = "Low-pass Sweep"
parameter = "p_lpf_ramp"
bipolar = true
[node name="ParamSlider5" parent="Editor/ScrollContainer/Params/Filter" instance=ExtResource( 3 )]
margin_top = 52.0
@ -366,6 +373,7 @@ margin_right = 242.0
margin_bottom = 126.0
label = "High-pass Sweep"
parameter = "p_hpf_ramp"
bipolar = true
[node name="PluginTranslator" parent="." instance=ExtResource( 5 )]

View File

@ -6,6 +6,7 @@ signal param_reset(name)
export var label: String setget set_label
export var parameter: String
export var bipolar := false setget set_bipolar
func set_label(v: String) -> void:
@ -13,6 +14,14 @@ func set_label(v: String) -> void:
$Label.text = v
func set_bipolar(v: bool) -> void:
bipolar = v
if bipolar:
$HSlider.min_value = -1.0
else:
$HSlider.min_value = 0.0
func set_value(v: float) -> void:
$HSlider.value = v

View File

@ -8,9 +8,6 @@ margin_right = 253.0
margin_bottom = 40.0
size_flags_horizontal = 3
script = ExtResource( 1 )
__meta__ = {
"_edit_use_anchors_": false
}
[node name="Label" type="Label" parent="."]
margin_top = 13.0